Skip to content

Make add by core contract case insensitive#1770

Merged
jribbink merged 2 commits into
masterfrom
jribbink/lower-alias
Sep 24, 2024
Merged

Make add by core contract case insensitive#1770
jribbink merged 2 commits into
masterfrom
jribbink/lower-alias

Conversation

@jribbink

@jribbink jribbink commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

Closes #1769


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Sep 24, 2024
@codecov-commenter

codecov-commenter commented Sep 24, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 29.65%. Comparing base (f99a061) to head (d91415d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/dependencymanager/add.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1770      +/-   ##
==========================================
- Coverage   29.68%   29.65%   -0.04%     
==========================================
  Files          89       89              
  Lines        5191     5197       +6     
==========================================
  Hits         1541     1541              
- Misses       3463     3469       +6     
  Partials      187      187              
Flag Coverage Δ
unittests 29.65% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jribbink jribbink merged commit 30eaa63 into master Sep 24, 2024
@jribbink jribbink deleted the jribbink/lower-alias branch September 24, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make flow deps add <core contract> case insensitive

4 participants