Refactor Generator#1772
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Member
|
@jribbink You tested this manually with |
Contributor
Author
Yup. No regressions. It fixes some issues in scripts/tx/test templates with missing values as well. |
chasefleming
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1774
Description
Most of the work is just reoganizing logic
Generator.generatefunction. This logic was all moved to the TemplateType structs. This helps us generalize a bit better without needing special handling for each new type (i.e. README.md, tests, and anything else in the future.I feel like this could be potentially abstracted further by breaking the template files themselves out of the generator, but probably out of scope for this PR/unnecessary right now and I think what's been changed in this PR is already an improvement.
For contributor use:
masterbranchFiles changedin the Github PR explorer