Skip to content

Add test filename suffix#1785

Merged
jribbink merged 2 commits into
masterfrom
jribbink/test-name
Oct 10, 2024
Merged

Add test filename suffix#1785
jribbink merged 2 commits into
masterfrom
jribbink/test-name

Conversation

@jribbink

@jribbink jribbink commented Oct 8, 2024

Copy link
Copy Markdown
Contributor

Closes #1786

Description

Adds suffix to test files, was a bit of an oversight when I added this feature.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter

codecov-commenter commented Oct 8, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/super/generate.go 0.00% 3 Missing ⚠️
internal/super/generator/test_template.go 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Oct 9, 2024
@jribbink jribbink merged commit b54a38f into master Oct 10, 2024
@jribbink jribbink deleted the jribbink/test-name branch October 10, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add _test suffix when generating test files

3 participants