Fall back to project root when file resolver cannot find file#2325
Merged
Fall back to project root when file resolver cannot find file#2325
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
janezpodhostnik
approved these changes
Apr 15, 2026
| tests.SomeFile.Source, | ||
| os.ModeTemporary, | ||
| ) | ||
| t.Parallel() |
Contributor
There was a problem hiding this comment.
can you move this to the top of the function?
Member
Author
There was a problem hiding this comment.
Not sure but all of the tests have same setup, I just copied it, would rather leave this consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fileResolveralways resolved file paths relative to the test file that triggered the import. This breaks when a helper script is shared across test files in different directories.For example, given this layout:
This essentially forces having all test files in a single directory.
The fix adds a fallback: if a file isn't found at the path relative to the test file, it retries the path relative to the project root (the working directory where
flow.jsonlives).The original error is returned only if both lookups fail, so existing behavior is fully preserved.
Any test that already works continues to work unchanged.