Skip to content

Temporarily disable concurrent test execution when collecting coverag… #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turbolent merged 2 commits into from
Apr 21, 2026
+14 −4
Merged

Temporarily disable concurrent test execution when collecting coverag… #2335

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
838d914
temporarily disable concurrent test execution when collecting coverag…
turbolent Apr 20, 2026
75b5655
warn that tests run sequentially if coverage is enabled
turbolent Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions internal/test/test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,16 @@ func run(
return nil, fmt.Errorf("the '--coverprofile' flag requires the '--cover' flag")
}
if testFlags.Random && testFlags.Seed > 0 {
fmt.Printf(
"%s Both '--seed' and '--random' flags are used. Hence, the '--random' flag will be ignored.\n",
logger.Info(fmt.Sprintf(
"%s Both '--seed' and '--random' flags are used. Hence, the '--random' flag will be ignored.",
output.WarningEmoji(),
)
))
}
if testFlags.Cover && testFlags.Jobs > 1 {
logger.Info(fmt.Sprintf(
"%s The '--jobs' flag is ignored when coverage is enabled. Tests will run sequentially.",
output.WarningEmoji(),
))
}

var filenames []string
Expand Down Expand Up @@ -273,8 +279,12 @@ func testCode(
}

// Limit concurrency to flags.Jobs, defaulting to number of CPU cores.
// When coverage is enabled, force sequential execution because the
// coverage report is shared across all test file goroutines.
jobs := flags.Jobs
if jobs <= 0 {
if flags.Cover {
Comment thread
turbolent marked this conversation as resolved.
jobs = 1
} else if jobs <= 0 {
jobs = goRuntime.NumCPU()
}
sem := make(chan struct{}, jobs)
Expand Down
Loading