Add prompts for build and send-signed#432
Conversation
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
- Coverage 55.50% 55.38% -0.13%
==========================================
Files 36 36
Lines 1906 1914 +8
==========================================
+ Hits 1058 1060 +2
- Misses 711 716 +5
- Partials 137 138 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| if !approveSend { | ||
| if !output.ApproveTransactionForSendingPrompt(tx) { |
There was a problem hiding this comment.
nit:
| if !approveSend { | |
| if !output.ApproveTransactionForSendingPrompt(tx) { | |
| if !approveSend && !output.ApproveTransactionForSendingPrompt(tx) { |
|
Thank you this is great. We just need to be careful to update LS accordingly as it uses this API. I can make a PR on top of that. The lining error is a nasty one, I was doing an update of dependencies and I will need to make a PR on Go SDK to stop using deprecated functionality, so as long as this is the only listing error I think we can merge until I fix that with PR, I plan to do that as soon as I get the time. |
Closes #410
Description
Adds prompt for the
sendsignedandbuildcommands.Currently auto accepts for the
sendcommand, as this is currently used in ways that make upgrading it less convenient and would require other work in additional repos. It's also less important, as it's a single step process so it should be "easier" to know what is being sent. Still would be good to have, but i think is a bigger lift for a smaller gain, so better to just tackle to two higher value commands first.For contributor use:
masterbranchFiles changedin the Github PR explorer