Skip to content

Conversation

@devbugging
Copy link
Contributor

@devbugging devbugging commented Feb 21, 2022

Description

This PR integrates the dev-wallet server into the CLI. This is the beginning of the tools section in the CLI and more will follow. Integration is straightforward since the dev-wallet itself is a module according to the PR onflow/fcl-dev-wallet#100


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@devbugging devbugging added the Feature A new user feature or a new package API label Feb 21, 2022
@devbugging devbugging requested a review from psiemens as a code owner February 21, 2022 12:50
@devbugging devbugging self-assigned this Feb 21, 2022
@devbugging devbugging marked this pull request as draft February 21, 2022 12:50
@devbugging
Copy link
Contributor Author

This is blocked until fcl-dev-wallet is refactored in a way it can be statically exported into a bundle.

@devbugging devbugging marked this pull request as ready for review March 14, 2022 11:27
Gregor Gololicic added 2 commits March 14, 2022 12:30
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #467 (1207c89) into master (0801f5d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #467   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files          37       37           
  Lines        2002     2002           
=======================================
  Hits         1101     1101           
  Misses        757      757           
  Partials      144      144           
Flag Coverage Δ
unittests 54.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0801f5d...1207c89. Read the comment docs.

@devbugging devbugging merged commit 2eafe0d into master Mar 21, 2022
@devbugging devbugging deleted the feature/dev-wallet branch March 21, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature A new user feature or a new package API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants