Skip to content

Conversation

@turbolent
Copy link
Member

Closes #495


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label May 6, 2022
@turbolent turbolent self-assigned this May 6, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #496 (3ecac61) into master (8f29dc3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #496   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files          37       37           
  Lines        2002     2002           
=======================================
  Hits         1101     1101           
  Misses        757      757           
  Partials      144      144           
Flag Coverage Δ
unittests 54.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f29dc3...3ecac61. Read the comment docs.

Copy link
Contributor

@devbugging devbugging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the CLI lighter :)

@turbolent
Copy link
Member Author

Linting passes locally with v1.45.2, CI seems to need an update

@turbolent turbolent merged commit 33e1363 into master May 6, 2022
@turbolent turbolent deleted the bastian/remove-vscode-extension branch May 6, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Visual Studio Code extension out-of-date

4 participants