Skip to content

Conversation

@ryokik
Copy link
Contributor

@ryokik ryokik commented May 18, 2022

Closes #474

Description

I made the install script work on docker container on an M1 mac.
A similar PR #475 has already been merged, but this wasn't for linux/arm64 (aarch64).


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Contributor

@devbugging devbugging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@codecov-commenter
Copy link

Codecov Report

Merging #506 (f3fdfa0) into master (db6d9af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #506   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files          37       37           
  Lines        2007     2007           
=======================================
  Hits         1105     1105           
  Misses        758      758           
  Partials      144      144           
Flag Coverage Δ
unittests 55.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db6d9af...f3fdfa0. Read the comment docs.

@devbugging devbugging merged commit b44fc41 into onflow:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flow CLI cannot be installed with Dockerized environment with curl on MacOS with M1 chip

3 participants