-
Notifications
You must be signed in to change notification settings - Fork 81
Feature/event tracking command count on mixpanel #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We need to implement an option to disable tracking in an opt-out fashion. MIxpanel allows setting such a property as seen here https://developer.mixpanel.com/docs/javascript#opting-users-out-of-tracking. |
|
The closest thing that I find with regards to the opt out on javascript sdk, is to use user properties as stated in https://developer.mixpanel.com/reference/profile-set. This means that we will start referencing each user to an ID, but since we are not linking their distinct id with the events (in this case the commands), we will not be able to see the commands that they call (which is what we want). Another option if we want to minimize tracking each user is to implement opt in option either in a new json (like settings.json) or implement a new key in flow.json (sth like tracking_enabled: true/false), so that we can have the option locally everytime. Thoughts on which way we should go? |
Co-authored-by: Gregor G. <75445744+sideninja@users.noreply.github.com>
Co-authored-by: Gregor G. <75445744+sideninja@users.noreply.github.com>
devbugging
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left small coments, LGTM
Closes #579
Description
Tracks command count through mixpanel. Events are tracked with name of format {mainCommand}-{subCommand}
e.g. accounts-get
For contributor use:
masterbranchFiles changedin the Github PR explorer