Add command 'keys derive' to derive public key from private key #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesign
requested review from
Kay-Zee,
devbugging,
janezpodhostnik and
psiemens
as code owners
devbugging
reviewed
Aug 1, 2022
internal/keys/generate.go
Outdated
| Seed string `flag:"seed" info:"Deterministic seed phrase"` | ||
| KeySigAlgo string `default:"ECDSA_P256" flag:"sig-algo" info:"Signature algorithm"` | ||
| Seed string `flag:"seed" info:"Deterministic seed phrase"` | ||
| FromPrivateKey string `flag:"from-private-key" info:"Use user private key instead of random"` |
Contributor
There was a problem hiding this comment.
It would be nice to also support FromPublicKey which would get private key from public key :D just kidding
Contributor
|
Thank you, this is great. I was just thinking if it makes sense for this to be under the |
Collaborator
Author
|
Sure I will update the PR, it makes more sense like that |
bluesign
changed the title
keys generate command
devbugging
reviewed
Aug 1, 2022
Contributor
devbugging
left a comment
devbugging
left a comment
There was a problem hiding this comment.
🙏 One last thing to add would be documentation for this. You can just copy this page and make some changes to it https://github.com/onflow/flow-cli/blob/master/docs/generate-keys.md
devbugging
reviewed
Aug 1, 2022
devbugging
approved these changes
Aug 1, 2022
Contributor
devbugging
left a comment
devbugging
left a comment
There was a problem hiding this comment.
Thank you! Small comment, but LGTM
Co-authored-by: Gregor G. <75445744+sideninja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #505
For contributor use:
masterbranchFiles changedin the Github PR explorer