Skip to content

Conversation

@sukantoraymond
Copy link
Contributor

@sukantoraymond sukantoraymond commented Aug 17, 2022

Closes #602

This PR changes version checking from google cloud version.txt to flow cli repo version.txt in install.sh and install.ps1


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@gpavlov2016
Copy link

I'm concerned about a situation where someone pushes an update to master with version update but does not release a new package right away to google - we will have a mismatch again.
More robust solution would be implementing verification and retries in case the version.txt upload failed during release.

@sukantoraymond
Copy link
Contributor Author

With this PR, no more checking google for version number. It will all come from version.txt in flow cli repo

@devbugging
Copy link
Contributor

Have you tested this out manually?

@sukantoraymond
Copy link
Contributor Author

Tested

Raymonds-MBP-3:flow-cli raymondsukanto$ sh install.sh
Downloading version v0.39.1 ...

@devbugging devbugging merged commit 69c46d4 into master Aug 22, 2022
@devbugging devbugging deleted the improvement/use-git-version.txt branch August 22, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

version.txt occasionally out of sync with latest version

4 participants