Skip to content

Conversation

@bluesign
Copy link
Collaborator

On the way to close #600

Description

This PR adds ability to define account keys with BIP44 ( as defined in https://github.com/onflow/flow/blob/master/flips/20201125-bip-44-multi-account.md )

Example config:

"emulator-account": {
	"address": "f8d6e0586b0a20c7",
	"key": {
		"type": "bip44",
		"index": 0,
		"signatureAlgorithm": "ECDSA_P256",
		"hashAlgorithm": "SHA3_256",
		"mnemonic": "skull design wagon top faith actor valley crystal subject volcano access join",
		"derivationPath": "m/44'/539'/0'/0/0"
	}
}
  • Derivation Path defaults to m/44'/539'/0'/0/0 if omitted.

If this is acceptable I will update the relevant documentation in this PR.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Contributor

@devbugging devbugging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just add comments otherwise LGTM

@devbugging
Copy link
Contributor

@bluesign sorry I meant just add the documentation.

@devbugging devbugging self-requested a review August 24, 2022 09:38
Copy link
Contributor

@devbugging devbugging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is awesome.

@devbugging devbugging merged commit 1d45f82 into onflow:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor key generate API

2 participants