Add mixpanel to emulator #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukantoraymond
requested review from
Kay-Zee,
devbugging,
janezpodhostnik and
psiemens
as code owners
sukantoraymond
commented
Aug 23, 2022
internal/emulator/start.go
Outdated
| var state *flowkit.State | ||
| var err error | ||
| loader := &afero.Afero{Fs: afero.NewOsFs()} | ||
| command.HandleUserTracking(Cmd, loader) |
Contributor
Author
There was a problem hiding this comment.
need to add this since emulator is not part of addtoparent
devbugging
reviewed
Aug 23, 2022
Contributor
|
Have you manually tested this usage of emulator and other commands? |
Contributor
Author
|
Already tested, they are being tracked in mixpanel |
devbugging
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add user tracking to emulator
For contributor use:
masterbranchFiles changedin the Github PR explorer