-
Notifications
You must be signed in to change notification settings - Fork 81
Integrate Cadence testing framework to the CLI #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@SupunS this is really awesome!!! 🔥 Thank you. Left some comments but nothing major. The one thing that is also lacking is documentation. Make sure to add that as you finish things up. |
b5e4a10 to
050c90f
Compare
…n/test-framework
16ed3fb to
811fa2e
Compare
811fa2e to
2f0b283
Compare
|
@sideninja I'll open a separate PR to add documentation, so that this PR doesn't get too big. |
|
The only question left here is, should we have this as top commands or not? why this changed from last time you were working on it is because I believe we will also add linter, so I'm now wondering should those commands be |
|
I'm happy with either way. I'm slightly leaning towards having the But for some of the other tools like |
turbolent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
devbugging
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you! Nice work
Work towards onflow/cadence#331
Description
This PR is to integrate the new Cadence testing framework into the CLI.
Command:
Sample output:
For contributor use:
masterbranchFiles changedin the Github PR explorer