Skip to content

Conversation

@devbugging
Copy link
Contributor

@devbugging devbugging commented Oct 18, 2022

Closes: #659

This is a PR addressing issues coming from the lack of canonical schema for transaction payloads. The problems is that some transactions are made from JS or other libs that produce a bit different format to how the format is in Go SDK thus causing the recalculation of those transaction ID to be different than to the one returned. So the solution is to pass ID to the get transaction result directly. After canonical schema is defined this will get better.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@devbugging devbugging merged commit 4867b17 into master Oct 19, 2022
@devbugging devbugging deleted the bugfix/no-transaction branch October 19, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flow-Cli 0.39.3 unable to retrieve transaction

3 participants