Bugfix transaction result use ID direclty #679
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #659
This is a PR addressing issues coming from the lack of canonical schema for transaction payloads. The problems is that some transactions are made from JS or other libs that produce a bit different format to how the format is in Go SDK thus causing the recalculation of those transaction ID to be different than to the one returned. So the solution is to pass ID to the get transaction result directly. After canonical schema is defined this will get better.
For contributor use:
masterbranchFiles changedin the Github PR explorer