Release process to two step #694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove building from publish
devbugging
added
the
Improvement
devbugging
requested review from
Kay-Zee,
janezpodhostnik and
psiemens
as code owners
turbolent
reviewed
Nov 14, 2022
go.mod
Outdated
| github.com/go-git/go-git/v5 v5.4.2 | ||
| github.com/manifoldco/promptui v0.9.0 | ||
| github.com/onflow/cadence v0.28.0 | ||
| github.com/onflow/cadence v0.29.0-stable-cadence-3 |
Member
There was a problem hiding this comment.
The Stable Cadence updates shouldn't be merged to master yet, right?
janezpodhostnik
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate release into a two-step process. The first is to build the binaries and upload them to our storage the second is once the release is created and we publish the release to homebrew.
We want to execute only the first process on tags beginning
v*because they might be used for unpublished releases (testing specific builds etc), while the publish to homebrew only executes when we also have a release.For contributor use:
masterbranchFiles changedin the Github PR explorer