Skip to content

Comments

update dependencies#245

Merged
joshuahannan merged 3 commits intomasterfrom
update-deps
Sep 22, 2021
Merged

update dependencies#245
joshuahannan merged 3 commits intomasterfrom
update-deps

Conversation

@joshuahannan
Copy link
Member

@joshuahannan joshuahannan commented Sep 15, 2021

This PR updates the dependencies to the latest cadence, flow-go-sdk, emulator, and flow-go

The cadence update required the cadence string function to be changed to support an error return value
The flow-go update required that we do not use the service account for any of the tests because it has conflicting storage paths with the tests

Also added an upgrade to the LockedTokens contract to allow extra TokenHolder objects to be created after the first and a transaction to create an extra one for a new account, along with a test

self.nodeStakerProxy = LockedNodeStakerProxy(tokenManager: self.tokenManager)

// create a new delegator proxy that can be accessed in transactions
self.nodeDelegatorProxy = LockedNodeDelegatorProxy(tokenManager: self.tokenManager)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So in the case of someone calling createNodeStaker after this upgrade, this will just get over-written, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but I can actually just remove the lines in createNodeStaker because they aren't needed anymore

Copy link
Member

@Kay-Zee Kay-Zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

            // Create a new staker proxy that can be accessed in transactions
            self.nodeStakerProxy = LockedNodeStakerProxy(tokenManager: self.tokenManager)

            // create a new delegator proxy that can be accessed in transactions
            self.nodeDelegatorProxy = LockedNodeDelegatorProxy(tokenManager: self.tokenManager)

Is the major change that i'm concerned with, and looks good to me.

Not sure about the dependency updates though

@joshuahannan joshuahannan merged commit 51b4191 into master Sep 22, 2021
@joshuahannan joshuahannan deleted the update-deps branch September 22, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants