Merged
Conversation
Kay-Zee
reviewed
Sep 22, 2021
| self.nodeStakerProxy = LockedNodeStakerProxy(tokenManager: self.tokenManager) | ||
|
|
||
| // create a new delegator proxy that can be accessed in transactions | ||
| self.nodeDelegatorProxy = LockedNodeDelegatorProxy(tokenManager: self.tokenManager) |
Member
There was a problem hiding this comment.
So in the case of someone calling createNodeStaker after this upgrade, this will just get over-written, right?
Member
Author
There was a problem hiding this comment.
yeah, but I can actually just remove the lines in createNodeStaker because they aren't needed anymore
Kay-Zee
approved these changes
Sep 22, 2021
Member
Kay-Zee
left a comment
There was a problem hiding this comment.
// Create a new staker proxy that can be accessed in transactions
self.nodeStakerProxy = LockedNodeStakerProxy(tokenManager: self.tokenManager)
// create a new delegator proxy that can be accessed in transactions
self.nodeDelegatorProxy = LockedNodeDelegatorProxy(tokenManager: self.tokenManager)
Is the major change that i'm concerned with, and looks good to me.
Not sure about the dependency updates though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependencies to the latest cadence, flow-go-sdk, emulator, and flow-go
The cadence update required the cadence string function to be changed to support an error return value
The flow-go update required that we do not use the service account for any of the tests because it has conflicting storage paths with the tests
Also added an upgrade to the
LockedTokenscontract to allow extraTokenHolderobjects to be created after the first and a transaction to create an extra one for a new account, along with a test