You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GET /snapshots to list all snapshots, in any case we should add, I guess, it seems pretty nice to have.
GET /snapshots/{snapshotID} Retrieve existing one is also not a problem. ( also 404 on fail )
But it will not be backwards compatible. But if we decide like that ( and move create to POST verb ) I can update the PR
For contributor use:
Targeted PR against master branch
Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
I would say that if we are doing changes in API I would make the API to be more RESTful: GET /snapshots list all POST /snapshots create a new snapshot, and provide a name in body PUT /snapshots/{id} restore a specific snapshot
@bluesign left a couple of questions, the biggest one is a check whether the store is of type badger, and also generally to think how will this work with the store refactor that happened meanwhile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #228
Description
I was thinking 2 endpoints:
GET /snapshots to list all snapshots, in any case we should add, I guess, it seems pretty nice to have.
GET /snapshots/{snapshotID} Retrieve existing one is also not a problem. ( also 404 on fail )
But it will not be backwards compatible. But if we decide like that ( and move create to POST verb ) I can update the PR
For contributor use:
masterbranchFiles changedin the GitHub PR explorer