Skip to content

Conversation

@janezpodhostnik
Copy link
Contributor

@janezpodhostnik janezpodhostnik commented Jan 27, 2021

ref: https://github.com/dapperlabs/flow-internal/issues/1384

Description

There are two changes here:

  • New flag to turn on transaction fees
  • Added logging the addresses of the deployed flow contracts (see image)

image


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@janezpodhostnik janezpodhostnik added the Improvement Technical work without new features, refactoring, improving tests label Jan 27, 2021
@janezpodhostnik janezpodhostnik self-assigned this Jan 27, 2021
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally missed this, nice!

}

func (b *Blockchain) GetChain() flowgo.Chain {
return b.vmCtx.Chain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Comment on lines +120 to +126
contracts := logrus.Fields{
"FlowServiceAccount": chain.ServiceAddress().HexWithPrefix(),
"FlowToken": fvm.FlowTokenAddress(chain).HexWithPrefix(),
"FungibleToken": fvm.FungibleTokenAddress(chain).HexWithPrefix(),
"FlowFees": fvm.FlowFeesAddress(chain).HexWithPrefix(),
"FlowStorageFees": chain.ServiceAddress().HexWithPrefix(),
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

janezpodhostnik and others added 3 commits February 3, 2021 20:40
@janezpodhostnik janezpodhostnik merged commit 3e3499f into master Feb 3, 2021
@janezpodhostnik janezpodhostnik deleted the janez/emulator-tx-fees branch March 9, 2021 15:57
tarakby pushed a commit that referenced this pull request Aug 4, 2023
Co-Authored-By: Bastian Müller <bastian@axiomzen.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants