Merged
Conversation
timmymmit
approved these changes
Apr 20, 2020
Contributor
timmymmit
left a comment
timmymmit
left a comment
There was a problem hiding this comment.
Approved, pending license confirmation
Member
laynelafrance
left a comment
laynelafrance
left a comment
There was a problem hiding this comment.
I'm going to email the lawyer and make 100% sure this unlicense thing is ok
Member
laynelafrance
left a comment
laynelafrance
left a comment
There was a problem hiding this comment.
Requesting review from our lawyer on the unlicense thing
joshuahannan
added a commit
that referenced
this pull request
Mar 10, 2026
Tests for the two fixes made in contracts/utility/TokenForwarding.cdc: 1. changeRecipient with stale old capability (bug fix #1): - testChangeRecipientSucceedsWhenOldCapabilityIsStale: verifies the transaction succeeds and the ForwarderRecipientUpdated event emits nil for oldRecipient when the old cap is no longer valid - testTokensForwardedToNewRecipientAfterChange: end-to-end check that tokens sent to the Forwarder after the update arrive at the new recipient, not the stale old one 2. getSupportedVaultTypes for chained forwarders (bug fix #2): - testGetSupportedVaultTypesForSingleForwarder: baseline check that a single Forwarder → Vault returns {ExampleToken.Vault: true} - testGetSupportedVaultTypesForChainedForwarders: the key regression test — Forwarder B → Forwarder A → Vault must return {ExampleToken.Vault: true}, not {TokenForwarding.Forwarder: true} Also adds tests/transactions/unload_example_token_vault.cdc, a test-only helper transaction that removes and destroys an account's ExampleToken vault to simulate a stale receiver capability. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
joshuahannan
added a commit
that referenced
this pull request
Mar 11, 2026
Tests for the two fixes made in contracts/utility/TokenForwarding.cdc: 1. changeRecipient with stale old capability (bug fix #1): - testChangeRecipientSucceedsWhenOldCapabilityIsStale: verifies the transaction succeeds and the ForwarderRecipientUpdated event emits nil for oldRecipient when the old cap is no longer valid - testTokensForwardedToNewRecipientAfterChange: end-to-end check that tokens sent to the Forwarder after the update arrive at the new recipient, not the stale old one 2. getSupportedVaultTypes for chained forwarders (bug fix #2): - testGetSupportedVaultTypesForSingleForwarder: baseline check that a single Forwarder → Vault returns {ExampleToken.Vault: true} - testGetSupportedVaultTypesForChainedForwarders: the key regression test — Forwarder B → Forwarder A → Vault must return {ExampleToken.Vault: true}, not {TokenForwarding.Forwarder: true} Also adds tests/transactions/unload_example_token_vault.cdc, a test-only helper transaction that removes and destroys an account's ExampleToken vault to simulate a stale receiver capability. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
joshuahannan
added a commit
that referenced
this pull request
Mar 11, 2026
Tests for the two fixes made in contracts/utility/TokenForwarding.cdc: 1. changeRecipient with stale old capability (bug fix #1): - testChangeRecipientSucceedsWhenOldCapabilityIsStale: verifies the transaction succeeds and the ForwarderRecipientUpdated event emits nil for oldRecipient when the old cap is no longer valid - testTokensForwardedToNewRecipientAfterChange: end-to-end check that tokens sent to the Forwarder after the update arrive at the new recipient, not the stale old one 2. getSupportedVaultTypes for chained forwarders (bug fix #2): - testGetSupportedVaultTypesForSingleForwarder: baseline check that a single Forwarder → Vault returns {ExampleToken.Vault: true} - testGetSupportedVaultTypesForChainedForwarders: the key regression test — Forwarder B → Forwarder A → Vault must return {ExampleToken.Vault: true}, not {TokenForwarding.Forwarder: true} Also adds tests/transactions/unload_example_token_vault.cdc, a test-only helper transaction that removes and destroys an account's ExampleToken vault to simulate a stale receiver capability. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added CODEOWNERS, contribution guidelines, code of conduct, license, copyright notice, and issue templates