Skip to content

align collection guarantee with protobuf schema#779

Merged
franklywatson merged 5 commits into
onflow:masterfrom
The-K-R-O-K:illia-malachyn/768-collection-guarantee-response-object
Oct 21, 2024
Merged

align collection guarantee with protobuf schema#779
franklywatson merged 5 commits into
onflow:masterfrom
The-K-R-O-K:illia-malachyn/768-collection-guarantee-response-object

Conversation

@illia-malachyn
Copy link
Copy Markdown
Contributor

Closes: #768

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.46%. Comparing base (7b58582) to head (276409c).
Report is 67 commits behind head on master.

Files with missing lines Patch % Lines
test/entities.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   52.92%   56.46%   +3.54%     
==========================================
  Files          35       35              
  Lines        5580     6007     +427     
==========================================
+ Hits         2953     3392     +439     
+ Misses       2231     2124     -107     
- Partials      396      491      +95     
Flag Coverage Δ
unittests 56.46% <92.00%> (+3.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illia-malachyn illia-malachyn force-pushed the illia-malachyn/768-collection-guarantee-response-object branch from 61deb51 to be6d7cc Compare October 15, 2024 14:55
Comment thread collection.go Outdated
@franklywatson franklywatson merged commit aadf896 into onflow:master Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CollectionGuarantee type differs from protobuf schema

5 participants