Ensure cadence don't access unexpected operations while parsing (part 3)#3359
Merged
Ensure cadence don't access unexpected operations while parsing (part 3)#3359
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3359 +/- ##
==========================================
+ Coverage 55.00% 55.02% +0.02%
==========================================
Files 734 694 -40
Lines 67341 65398 -1943
==========================================
- Hits 37040 35985 -1055
+ Misses 27264 26412 -852
+ Partials 3037 3001 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
FVM Benchstat comparisonThis branch with compared with the base branch onflow:master commit 4cd3c83 The command Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
pattyshack
force-pushed
the
patrick/parse-restrict-3
branch
from
2f77bd3 to
0deefba
Compare
Tonix517
approved these changes
Oct 13, 2022
| } | ||
|
|
||
| return callback(arg) | ||
| } |
Contributor
There was a problem hiding this comment.
iirc golang does not have plan to support generic variadic functions. i'm thinking combining https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source and "text/template" may save us some typing here. but just for entertainment purposes, it is too hacky for production.
Contributor
Author
There was a problem hiding this comment.
not supporting adhoc (i.e., overloading / variadic) polymorphism is the correct thing to do from the language designer's perspective. unlike parametric polymorphism, there's no solid theoretical foundation for adhoc polymorphism.
Contributor
There was a problem hiding this comment.
this is why i hate C++ ;)
pattyshack
force-pushed
the
patrick/parse-restrict-3
branch
from
0deefba to
6e6782f
Compare
SaveTheRbtz
approved these changes
Oct 13, 2022
Contributor
Author
|
bors merge |
Contributor
janezpodhostnik
approved these changes
Oct 14, 2022
Contributor
janezpodhostnik
left a comment
janezpodhostnik
left a comment
There was a problem hiding this comment.
Hmmm... It might be time to unify opCode, SpanName and common.ComputationKind and use a operation wrapper like the parseRestricted to not only check for IsParseRestricted but also do:
defer info.tracer.StartSpanFromRoot(opCode).End()
err := info.meter.MeterComputation(opCode, intensity())
Contributor
Author
|
yeah, that's reasonable. |
Contributor
|
+1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.