[Checkpoint v6] Refactor file close error#3368
Merged
zhangchiqing merged 3 commits intofeature-checkpoint-v6from Oct 12, 2022
Merged
[Checkpoint v6] Refactor file close error#3368zhangchiqing merged 3 commits intofeature-checkpoint-v6from
zhangchiqing merged 3 commits intofeature-checkpoint-v6from
Conversation
zhangchiqing
force-pushed
the
leo/checkpoint-v6-refactor-file-close-error
branch
from
a1d91d5 to
f04252e
Compare
zhangchiqing
requested review from
SaveTheRbtz,
Tonix517,
fxamacker,
m4ksio and
pattyshack
zhangchiqing
commented
Oct 11, 2022
| func OpenAndReadCheckpointV6(dir string, fileName string, logger *zerolog.Logger) ([]*trie.MTrie, error) { | ||
| func OpenAndReadCheckpointV6(dir string, fileName string, logger *zerolog.Logger) ( | ||
| tries []*trie.MTrie, | ||
| errToReturn error, |
Member
Author
There was a problem hiding this comment.
if you are thinking why not just err, then please read the comments on closeAndMergeError
zhangchiqing
commented
Oct 11, 2022
| // any error returned are exceptions | ||
| func readCheckpointHeader(filepath string, logger *zerolog.Logger) ([]uint32, uint32, error) { | ||
| func readCheckpointHeader(filepath string, logger *zerolog.Logger) ( | ||
| checksumsOfSubtries []uint32, |
Member
Author
There was a problem hiding this comment.
I intended to have this verbose name, it is to ensure it's not being used and only for definition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.