Skip to content

[BFT] add suspicious flag to a few new log messages#3376

Merged
bors[bot] merged 6 commits intomasterfrom
petera/add-labels-to-bft-events-part2
Oct 18, 2022
Merged

[BFT] add suspicious flag to a few new log messages#3376
bors[bot] merged 6 commits intomasterfrom
petera/add-labels-to-bft-events-part2

Conversation

@peterargue
Copy link
Contributor

This is a follow on from #3346.

Add the suspicious flag to a few more log events.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2022

Codecov Report

Merging #3376 (84dc281) into master (54840e4) will increase coverage by 0.18%.
The diff coverage is 62.69%.

@@            Coverage Diff             @@
##           master    #3376      +/-   ##
==========================================
+ Coverage   55.28%   55.47%   +0.18%     
==========================================
  Files         744      752       +8     
  Lines       67865    68494     +629     
==========================================
+ Hits        37521    37996     +475     
- Misses      27293    27424     +131     
- Partials     3051     3074      +23     
Flag Coverage Δ
unittests 55.47% <62.69%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
admin/commands/storage/helper.go 78.00% <ø> (ø)
admin/commands/storage/read_results.go 72.60% <0.00%> (ø)
admin/commands/storage/read_seals.go 22.32% <0.00%> (ø)
admin/errors.go 0.00% <0.00%> (ø)
cmd/execution_builder.go 0.00% <0.00%> (ø)
cmd/scaffold.go 18.05% <0.00%> (-0.10%) ⬇️
cmd/verification_builder.go 0.00% <0.00%> (ø)
engine/access/rest/router.go 100.00% <ø> (ø)
fvm/environment/env.go 100.00% <ø> (ø)
fvm/environment/meter.go 81.63% <ø> (-0.73%) ⬇️
... and 74 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

// This means the message was received on a channel that the node has not registered an engine for
logger.Err(err).
Bool(logging.KeySuspicious, true).
Msg("failed to submit message")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peterargue
Copy link
Contributor Author

bors merge

@bors bors bot merged commit b243d75 into master Oct 18, 2022
@bors bors bot deleted the petera/add-labels-to-bft-events-part2 branch October 18, 2022 19:03
peterargue added a commit that referenced this pull request Oct 18, 2022
3376: [BFT] add suspicious flag to a few new log messages r=peterargue a=peterargue

This is a follow on from #3346.

Add the `suspicious` flag to a few more log events.

Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants