Skip to content

Conversation

@zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented Dec 29, 2025

This PR fixes the failed test case, and now is passing.

  === NAME  TestAccountRestricting/set_and_reject
      fvm_test.go:4404: 
          	Error Trace:	/home/runner/work/flow-go/flow-go/fvm/fvm_test.go:4404
          	            				/home/runner/work/flow-go/flow-go/fvm/fvm_test.go:112
          	Error:      	An error is expected but got nil.
          	Test:       	TestAccountRestricting/set_and_reject

@zhangchiqing zhangchiqing marked this pull request as ready for review December 29, 2025 21:31
@zhangchiqing zhangchiqing requested a review from a team as a code owner December 29, 2025 21:31
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for updating this!

@zhangchiqing zhangchiqing merged commit 2cb9c0a into bastian/account-restriction-exception-for-service-account Dec 29, 2025
@zhangchiqing zhangchiqing deleted the leo/review-comments-changes-for-8275 branch December 29, 2025 21:39
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants