Skip to content

[Access] Add override for 0.46.1#8488

Merged
peterargue merged 2 commits intomasterfrom
peter/add-missing-override
Mar 16, 2026
Merged

[Access] Add override for 0.46.1#8488
peterargue merged 2 commits intomasterfrom
peter/add-missing-override

Conversation

@peterargue
Copy link
Copy Markdown
Contributor

@peterargue peterargue commented Mar 14, 2026

Summary by CodeRabbit

  • Chores
    • Updated version compatibility management for version 0.46.1.

@peterargue peterargue requested a review from a team as a code owner March 14, 2026 12:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bfdc66c9-5b10-4107-8576-cb6f2ca26d4d

📥 Commits

Reviewing files that changed from the base of the PR and between 076aa90 and b51ffdd.

📒 Files selected for processing (1)
  • engine/common/version/version_control.go

📝 Walkthrough

Walkthrough

This pull request adds a single version entry "0.46.1" to the defaultCompatibilityOverrides map in the version control module, designating this version as exempt from compatibility checks. No functional logic or exported API changes are involved.

Changes

Cohort / File(s) Summary
Version Compatibility Configuration
engine/common/version/version_control.go
Added "0.46.1" to the defaultCompatibilityOverrides map to exclude this version from compatibility validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • vishalchangrani
  • zhangchiqing
  • turbolent
  • janezpodhostnik

Poem

🐰 A little hop through compatibility lands,
Where versions bloom like carrots in the sands,
We've marked 0.46.1 with care,
Exempt from checks, without a hare,
Our override map grows, perfectly fair! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[Access] Add override for 0.46.1' directly and specifically describes the main change: adding a compatibility override for version 0.46.1 to the defaultCompatibilityOverrides map.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch peter/add-missing-override
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@blacksmith-sh
Copy link
Copy Markdown

blacksmith-sh bot commented Mar 14, 2026

Found 8 test failures on Blacksmith runners:

Failures

Test View Logs
github.com/onflow/flow-go/integration/tests/epochs/cohort2/TestEpochJoinAndLeaveSN View Logs
github.com/onflow/flow-go/integration/tests/epochs/cohort2/TestEpochJoinAndLeaveSN View Logs
github.com/onflow/flow-go/integration/tests/epochs/cohort2/TestEpochJoinAndLeaveSN View Logs
github.com/onflow/flow-go/integration/tests/epochs/cohort2/TestEpochJoinAndLeaveSN View Logs
github.com/onflow/flow-go/integration/tests/epochs/cohort2/TestEpochJoinAndLeaveSN/
TestEpochJoinAndLeaveSN
View Logs
github.com/onflow/flow-go/integration/tests/epochs/cohort2/TestEpochJoinAndLeaveSN/
TestEpochJoinAndLeaveSN
View Logs
github.com/onflow/flow-go/integration/tests/epochs/cohort2/TestEpochJoinAndLeaveSN/
TestEpochJoinAndLeaveSN
View Logs
github.com/onflow/flow-go/integration/tests/epochs/cohort2/TestEpochJoinAndLeaveSN/
TestEpochJoinAndLeaveSN
View Logs

Fix in Cursor

@peterargue peterargue added this pull request to the merge queue Mar 16, 2026
Merged via the queue into master with commit dee4396 Mar 16, 2026
173 of 175 checks passed
@peterargue peterargue deleted the peter/add-missing-override branch March 16, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants