Skip to content

Handle ejected node in role based limit checks#8528

Merged
peterargue merged 1 commit into
leo/228-networkingfrom
peter/228-networking-ejected
Apr 8, 2026
Merged

Handle ejected node in role based limit checks#8528
peterargue merged 1 commit into
leo/228-networkingfrom
peter/228-networking-ejected

Conversation

@peterargue
Copy link
Copy Markdown
Contributor

The original PR followed an incorrect pattern from the network.go file, where the identity from n.Identity() wasn't checked to make sure it was not ejected. This PR adds this check to the unicast role based limit functionality, and also fixes another instance in the file.

It also fixes a typo in one of the slashing consumer names.

@peterargue peterargue requested a review from a team as a code owner April 8, 2026 16:12
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f562fcb0-7179-4c66-b570-b63edb0454e4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch peter/228-networking-ejected

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@peterargue peterargue merged commit 5765d71 into leo/228-networking Apr 8, 2026
@peterargue peterargue deleted the peter/228-networking-ejected branch April 8, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant