normalize cluster topic labels in metrics to prevent unbounded cardin…

[zhangchiqing]

local_mesh_size{topic="consensus-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ local_mesh_size{topic="consensus-cluster"}

graft_topic_total{topic="sync-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ graft_topic_total{topic="sync-cluster"}

prune_topic_total{topic="consensus-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ prune_topic_total{topic="consensus-cluster"}

received_ihave_message_ids{channel="sync-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ received_ihave_message_ids{channel="sync-cluster"}

time_in_mesh_quantum_count{channel="consensus-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ time_in_mesh_quantum_count{channel="consensus-cluster"}

mesh_message_delivery{channel="sync-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ mesh_message_delivery{channel="sync-cluster"}

first_message_delivery_count{channel="consensus-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ first_message_delivery_count{channel="consensus-cluster"}

invalid_message_delivery_count{channel="sync-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ invalid_message_delivery_count{channel="sync-cluster"}

inbound_message_size_bytes{channel="consensus-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ inbound_message_size_bytes{channel="consensus-cluster"}

outbound_message_size_bytes{channel="sync-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ outbound_message_size_bytes{channel="sync-cluster"}

duplicate_messages_dropped{channel="consensus-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ duplicate_messages_dropped{channel="consensus-cluster"}

current_messages_processing{topic="sync-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ current_messages_processing{topic="sync-cluster"}

engine_message_processing_time_seconds{topic="consensus-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ engine_message_processing_time_seconds{topic="consensus-cluster"}

direct_messages_in_progress{topic="sync-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ direct_messages_in_progress{topic="sync-cluster"}

unauthorized_messages_count{topic="consensus-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ unauthorized_messages_count{topic="consensus-cluster"}

rate_limited_unicast_messages_count{topic="sync-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ rate_limited_unicast_messages_count{topic="sync-cluster"}

reported_misbehavior_total{channel="consensus-cluster-cluster-232-d9efe2a782b6967a8c0854f9c23c9d3e..."}
→ reported_misbehavior_total{channel="consensus-cluster"}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 137ebe97-cbd9-4f4f-9a33-2c523b843ff2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch leo/cleanup-stale-cluster-metrics-aggregate

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[zhangchiqing]

Before (master):
The topic name contains epoch id and hash:

"network_gossip_direct_messages_in_progress{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_first_message_delivery_count_bucket{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_first_message_delivery_count_bucket{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_first_message_delivery_count_count{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_first_message_delivery_count_count{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_first_message_delivery_count_sum{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_first_message_delivery_count_sum{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_graft_topic_total{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_graft_topic_total{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_bucket{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_bucket{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_count{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_count{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_sum{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_sum{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_local_mesh_size{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_local_mesh_size{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_mesh_message_delivery_bucket{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_mesh_message_delivery_bucket{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_mesh_message_delivery_count{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_mesh_message_delivery_count{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_mesh_message_delivery_sum{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_mesh_message_delivery_sum{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_bucket{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_bucket{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_count{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_count{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_sum{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_sum{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_inbound_message_size_bytes_bucket{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_inbound_message_size_bytes_bucket{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_inbound_message_size_bytes_count{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_inbound_message_size_bytes_count{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_inbound_message_size_bytes_sum{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_inbound_message_size_bytes_sum{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_outbound_message_size_bytes_bucket{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_outbound_message_size_bytes_bucket{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_outbound_message_size_bytes_count{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_outbound_message_size_bytes_count{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_outbound_message_size_bytes_sum{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_gossip_outbound_message_size_bytes_sum{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_queue_current_messages_processing{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_queue_current_messages_processing{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_queue_engine_message_processing_time_seconds{topic=\"consensus-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"
"network_queue_engine_message_processing_time_seconds{topic=\"sync-cluster-cluster-0-3ecb05b373c5e1baa236bb55d4ec13cdcb0bce0faefb804296bc3168de76629a\"}"

After (leo/cleanup-stale-cluster-metrics-aggregate):

The topic is all normalized, only has consensus-cluster and sync-cluster without epoch id and hash.

curl -s -G 'http://localhost:9090/api/v1/series' \
        --data-urlencode 'match[]={topic=~".*cluster.*"}' | \
        jq '.data[] | "\(.__name__){topic=\"\(.topic)\"}"' | sort -u

"network_gossip_direct_messages_in_progress{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_first_message_delivery_count_bucket{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_first_message_delivery_count_bucket{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_first_message_delivery_count_count{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_first_message_delivery_count_count{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_first_message_delivery_count_sum{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_first_message_delivery_count_sum{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_graft_topic_total{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_graft_topic_total{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_bucket{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_bucket{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_count{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_count{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_sum{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_invalid_message_delivery_count_sum{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_local_mesh_size{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_local_mesh_size{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_mesh_message_delivery_bucket{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_mesh_message_delivery_bucket{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_mesh_message_delivery_count{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_mesh_message_delivery_count{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_mesh_message_delivery_sum{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_mesh_message_delivery_sum{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_bucket{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_bucket{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_count{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_count{topic=\"sync-cluster\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_sum{topic=\"consensus-cluster\"}"
"network_gossip_gossipsub_time_in_mesh_quantum_count_sum{topic=\"sync-cluster\"}"
"network_gossip_inbound_message_size_bytes_bucket{topic=\"consensus-cluster\"}"
"network_gossip_inbound_message_size_bytes_bucket{topic=\"sync-cluster\"}"
"network_gossip_inbound_message_size_bytes_count{topic=\"consensus-cluster\"}"
"network_gossip_inbound_message_size_bytes_count{topic=\"sync-cluster\"}"
"network_gossip_inbound_message_size_bytes_sum{topic=\"consensus-cluster\"}"
"network_gossip_inbound_message_size_bytes_sum{topic=\"sync-cluster\"}"
"network_gossip_outbound_message_size_bytes_bucket{topic=\"consensus-cluster\"}"
"network_gossip_outbound_message_size_bytes_bucket{topic=\"sync-cluster\"}"
"network_gossip_outbound_message_size_bytes_count{topic=\"consensus-cluster\"}"
"network_gossip_outbound_message_size_bytes_count{topic=\"sync-cluster\"}"
"network_gossip_outbound_message_size_bytes_sum{topic=\"consensus-cluster\"}"
"network_gossip_outbound_message_size_bytes_sum{topic=\"sync-cluster\"}"
"network_queue_current_messages_processing{topic=\"consensus-cluster\"}"
"network_queue_current_messages_processing{topic=\"sync-cluster\"}"
"network_queue_engine_message_processing_time_seconds{topic=\"consensus-cluster\"}"
"network_queue_engine_message_processing_time_seconds{topic=\"sync-cluster\"}"