Skip to content

Fix spinner race condition #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holyfuchs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix spinner race condition #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions output/spinner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ package output

import (
"fmt"
"sync"
"time"

"github.com/gosuri/uilive"
)

var spinnerCharset = []rune{'⠋', '⠙', '⠹', '⠸', '⠼', '⠴', '⠦', '⠧', '⠇', '⠏'}
var mu = sync.Mutex{}

type Spinner struct {
prefix string
Expand All @@ -46,7 +48,10 @@ func (s *Spinner) Start() {
}

func (s *Spinner) run() {
mu.Lock()
// writes to global variable, need a global lock to avoid race conditions
writer := uilive.New()
mu.Unlock()

ticker := time.NewTicker(100 * time.Millisecond)

Expand All @@ -56,7 +61,10 @@ func (s *Spinner) run() {
select {
case <-s.done:
_, _ = fmt.Fprintf(writer, "\r")
mu.Lock()
// writes to global variable, need a global lock to avoid race conditions
_ = writer.Flush()
mu.Unlock()
close(s.done)
return
case <-ticker.C:
Expand Down
Loading