Skip to content

Add getSystemTransaction function#99

Merged
mfbz merged 4 commits intomainfrom
mfbz/add-get-system-transaction
Apr 9, 2025
Merged

Add getSystemTransaction function#99
mfbz merged 4 commits intomainfrom
mfbz/add-get-system-transaction

Conversation

@mfbz
Copy link
Copy Markdown
Contributor

@mfbz mfbz commented Apr 7, 2025

The implementation for issue #98

  • Added getSystemTransaction function that retrieves data for a system transaction for block id.
  • Reverted onflow/go-ethereum from v1.14.8 to v1.14.7 for compatibility issues with other flow go packages that are not yet updated (like onflow/flow-evm-gateway).
  • Regenerated mocks with updated function

@mfbz mfbz changed the title Mfbz/add get system transaction Add getSystemTransaction function Apr 7, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 7, 2025

Codecov Report

❌ Patch coverage is 35.65217% with 74 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mocks/Services.go 0.00% 29 Missing ⚠️
gateway/mocks/Gateway.go 50.00% 10 Missing and 12 partials ⚠️
gateway/grpc.go 0.00% 7 Missing ⚠️
flowkit.go 53.84% 4 Missing and 2 partials ⚠️
mocks/services_mock.go 0.00% 6 Missing ⚠️
gateway/emulator.go 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread go.mod
Comment thread flowkit.go
@mfbz mfbz requested a review from jribbink April 9, 2025 08:39
Comment thread go.mod
@mfbz mfbz merged commit 9369af2 into main Apr 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants