fix: ArrayIndexOutOfBoundsException on empty string after mapping#101
Merged
fix: ArrayIndexOutOfBoundsException on empty string after mapping#101
Conversation
If the mapping phase (Step 1) or Normalization phase (Step 2) resulted in an empty string (e.g., a string consisting entirely of characters mapped to "nothing"), the code would throw an ArrayIndexOutOfBoundsException. Now there is a guard clause to return early if the value length is zero.
Improve throughput and reduce heap churn, use a "fast-path" check using Normalizer.isNormalized. Normalizer.normalize() always allocates a new buffer/string; this is avoided if the string is already normalized.
Introduced SecureStringBuilder to handle sensitive data during stringprep operations. Unlike standard StringBuilder, this implementation ensures internal buffers are zeroed out on resize and closure to mitigate memory exposure of cryptographic material.
Refactored Stringprep to store the EnumSet directly instead of unpacking it into 18 individual boolean flags. This eliminates constructor boilerplate, reduces class bloat, and simplifies the internal state.
6c3c89a to
7c13108
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: ArrayIndexOutOfBoundsException on empty string after mapping
If the mapping phase (Step 1) or Normalization phase (Step 2) resulted
in an empty string (e.g., a string consisting entirely of characters
mapped to "nothing"), the code would throw an ArrayIndexOutOfBoundsException.
Now there is a guard clause to return early if the value length is zero.
fix: add Normalizer.isNormalized guard to avoid allocations
Improve throughput and reduce heap churn, use a "fast-path" check using
Normalizer.isNormalized. Normalizer.normalize() always allocates a new
buffer/string; this is avoided if the string is already normalized.
feat: add SecureStringBuilder for memory-safe string building
Introduced SecureStringBuilder to handle sensitive data during
stringprep operations. Unlike standard StringBuilder, this
implementation ensures internal buffers are zeroed out on resize and
closure to mitigate memory exposure of cryptographic material.
chore: replace individual boolean flags with EnumSet from profile
Refactored Stringprep to store the EnumSet directly instead of unpacking
it into 18 individual boolean flags. This eliminates constructor
boilerplate, reduces class bloat, and simplifies the internal state.