Merged
Conversation
feat: rename `DefaultTextCreator` to `DefaultTextProducer`
Simplify captcha component configuration by replacing constructor-based initialisation with builder pattern. This improves readability and makes default values more explicit while maintaining the same functionality.
Move gradle-wrapper.jar exclusion to correct path and adjust general jar exclusion pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the default text producer component of the CAPTCHA library by renaming
DefaultTextCreatortoDefaultTextProducerthroughout the codebase. It also updates the builder pattern usage and improves the example usage in theREADME.mdto reflect these changes and promote builder usage for configuration. The update ensures consistency and clarity in naming, and modernizes the example for better usability.Core Refactoring:
DefaultTextCreatortoDefaultTextProducerand updated all references, including the builder class and method names, to improve clarity and consistency in naming. (src/main/java/com/onixbyte/captcha/text/impl/DefaultTextProducer.java, previouslyDefaultTextCreator.java) [1] [2] [3] [4] [5] [6] [7] [8]Documentation and Example Updates:
README.mdexample to use the newDefaultTextProducerand its builder, and to use builder patterns for other CAPTCHA components, making the example clearer and more maintainable.Other Minor Changes:
NoNoiseProducerdue to the refactoring.gradle-wrapper.properties.