Skip to content

Conversation

@masnwilliams
Copy link
Contributor

@masnwilliams masnwilliams commented Sep 5, 2025

TL;DR

Fixes the OAuth2 authentication flow by sending client credentials in the request body, as required by the provider.

Why we made these changes

The upstream OAuth2 provider expects the client_id and client_secret to be in the request parameters during the token exchange. The previous configuration sent them in the Authorization header, causing authentication to fail.

What changed?

  • Set AuthStyle: oauth2.AuthStyleInParams in the oauth2.Config. This forces the credentials into the request body, allowing the token exchange to succeed.

Description generated by Mesa. Update settings

@masnwilliams masnwilliams requested a review from rgarcia September 5, 2025 20:09
Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 191c318...0c338c1

Tip

⚡ Quick Actions

This review was generated by Mesa.

Actions:

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

1 files reviewed | 1 comments | Review on Mesa | Edit Reviewer Settings

@masnwilliams masnwilliams merged commit b0c753d into main Sep 5, 2025
2 checks passed
@masnwilliams masnwilliams deleted the mason/oauth2-config-cleanup branch September 5, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants