Skip to content

Conversation

@stainless-app
Copy link
Contributor

@stainless-app stainless-app bot commented Oct 31, 2025

Automated Release PR

0.18.1 (2025-11-04)

Full Changelog: v0.18.0...v0.18.1

Chores

  • internal/tests: avoid race condition with implicit client cleanup (4d011fd)
  • internal: grammar fix (it's -> its) (fcdf068)

This pull request is managed by Stainless's GitHub App.

The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.

For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.

🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions

@stainless-app
Copy link
Contributor Author

stainless-app bot commented Oct 31, 2025

🧪 Testing

    To try out this version of the SDK, run:
    ```
    pip install 'https://pkg.stainless.com/s/kernel-python/fcdf06877b370bf8c2abe047c5dcff7597dfadd9/kernel-0.18.0-py3-none-any.whl'
    ```

    _Expires: Thu, 04 Dec 2025 03:52:32 GMT_

@mesa-dot-dev
Copy link

mesa-dot-dev bot commented Oct 31, 2025

Mesa Description

Automated Release PR

0.18.1 (2025-11-04)

Full Changelog: v0.18.0...v0.18.1

Chores

  • internal/tests: avoid race condition with implicit client cleanup (4d011fd)
  • internal: grammar fix (it's -> its) (fcdf068)

This pull request is managed by Stainless's GitHub App.

The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.

For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.

🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions

Description generated by Mesa. Update settings

Copy link

@mesa-dot-dev mesa-dot-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed full review of 5fdbd6b...13851d8

Analysis

  1. Test Fixture Inconsistency: Three methods in the TestAsyncKernel class (test_request_extra_json, test_request_extra_headers, and test_request_extra_query) incorrectly use the synchronous client: Kernel fixture instead of the expected async_client: AsyncKernel fixture, potentially causing inconsistent test results.

  2. Resource Management Testing Gap: While the PR improves resource cleanup by explicitly closing client connections, there appears to be no verification or assertion that these resources are actually closed properly.

  3. Version Synchronization Complexity: Maintaining version numbers across multiple files (manifest, changelog, pyproject.toml, _version.py) introduces coupling that could lead to inconsistencies in future updates if not all files are modified together.

Tip

Help

Configure your agents

Mesa Docs

Slash Commands:

  • /review - Request a full code review
  • /review latest - Review only changes since the last review
  • /describe - Generate PR description. This will update the PR body or issue comment depending on your configuration
  • /help - Get help with Mesa commands and configuration options

5 files reviewed | 0 comments | Edit Agent Settings

@stainless-app stainless-app bot force-pushed the release-please--branches--main--changes--next branch from 13851d8 to bdcc902 Compare November 4, 2025 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant