-
Notifications
You must be signed in to change notification settings - Fork 1
release: 0.18.1 #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
release: 0.18.1 #54
Conversation
|
🧪 Testing |
Mesa DescriptionAutomated Release PR0.18.1 (2025-11-04)Full Changelog: v0.18.0...v0.18.1 Chores
This pull request is managed by Stainless's GitHub App. The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request. For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request. 🔗 Stainless website Description generated by Mesa. Update settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performed full review of 5fdbd6b...13851d8
Analysis
-
Test Fixture Inconsistency: Three methods in the
TestAsyncKernelclass (test_request_extra_json,test_request_extra_headers, andtest_request_extra_query) incorrectly use the synchronousclient: Kernelfixture instead of the expectedasync_client: AsyncKernelfixture, potentially causing inconsistent test results. -
Resource Management Testing Gap: While the PR improves resource cleanup by explicitly closing client connections, there appears to be no verification or assertion that these resources are actually closed properly.
-
Version Synchronization Complexity: Maintaining version numbers across multiple files (manifest, changelog, pyproject.toml, _version.py) introduces coupling that could lead to inconsistencies in future updates if not all files are modified together.
Tip
Help
Slash Commands:
/review- Request a full code review/review latest- Review only changes since the last review/describe- Generate PR description. This will update the PR body or issue comment depending on your configuration/help- Get help with Mesa commands and configuration options
5 files reviewed | 0 comments | Edit Agent Settings
13851d8 to
bdcc902
Compare
Automated Release PR
0.18.1 (2025-11-04)
Full Changelog: v0.18.0...v0.18.1
Chores
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions