Skip to content

Conversation

@K-Beicher
Copy link
Collaborator

@K-Beicher K-Beicher commented Nov 27, 2025

Description

Finished the data selection and preservation section.

Closes #82

This PR needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@K-Beicher K-Beicher self-assigned this Nov 27, 2025
@K-Beicher K-Beicher requested a review from a team as a code owner November 27, 2025 09:15
@K-Beicher K-Beicher moved this from Todo to In Review in Data Activity Nov 27, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just some minor comments/changes.

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Data Activity Nov 27, 2025
@lwjohnst86 lwjohnst86 changed the title feat: data selection and preservation feat: ✨ data selection and preservation Nov 27, 2025
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
@K-Beicher K-Beicher moved this from In Progress to In Review in Data Activity Nov 28, 2025
danielibsen
danielibsen previously approved these changes Nov 30, 2025
should have done them in one go!
@K-Beicher K-Beicher requested a review from lwjohnst86 December 2, 2025 09:22
@K-Beicher
Copy link
Collaborator Author

@lwjohnst86 This just needs an approval before it can be merged.

Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions to remove empty lines, otherwise 👍

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Data Activity Dec 5, 2025
@lwjohnst86 lwjohnst86 enabled auto-merge (squash) December 5, 2025 08:27
@lwjohnst86 lwjohnst86 disabled auto-merge December 5, 2025 08:27
@lwjohnst86 lwjohnst86 merged commit 552d925 into main Dec 5, 2025
2 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/selection-and-preservation branch December 5, 2025 08:29
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data Activity Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

DMP: Selection and Preservation of data

4 participants