Skip to content

Conversation

@K-Beicher
Copy link
Collaborator

Description

I've tried to put together the guidance on naming conventions for files and variables based mostly on the established practices from SDCC. I've placed it in a new folder. We can have a chat about whether or not we want to move it to a different repo later.

Closes #132

This PR needs an in-depth review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@K-Beicher K-Beicher self-assigned this Dec 5, 2025
@K-Beicher K-Beicher requested a review from a team as a code owner December 5, 2025 12:26
@K-Beicher K-Beicher linked an issue Dec 5, 2025 that may be closed by this pull request
@K-Beicher K-Beicher moved this from Todo to In Review in Data Activity Dec 5, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review pass ☺️

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Data Activity Dec 5, 2025
K-Beicher and others added 2 commits December 8, 2025 08:41
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Data Activity Dec 8, 2025
@lwjohnst86 lwjohnst86 moved this from In Review to In Progress in Data Activity Dec 8, 2025
@K-Beicher K-Beicher moved this from In Progress to In Review in Data Activity Dec 8, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some more mostly formatting changes.

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Data Activity Dec 8, 2025
@lwjohnst86 lwjohnst86 changed the title feat: naming convention for files and variables feat: ✨ naming convention for files and variables Dec 8, 2025
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
@K-Beicher K-Beicher moved this from In Progress to In Review in Data Activity Dec 8, 2025
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Data Activity Dec 15, 2025
@lwjohnst86 lwjohnst86 merged commit 2f4462a into main Dec 15, 2025
2 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/naming-fields-files branch December 15, 2025 08:41
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data Activity Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Look at file naming convention for csv uploads per participant

4 participants