-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ naming convention for files and variables #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lwjohnst86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review pass
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
lwjohnst86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some more mostly formatting changes.
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
lwjohnst86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
I've tried to put together the guidance on naming conventions for files and variables based mostly on the established practices from SDCC. I've placed it in a new folder. We can have a chat about whether or not we want to move it to a different repo later.
Closes #132
This PR needs an in-depth review.
Checklist
just run-all