fix(landing): stabilize TextRotator and improve hero layout#120
Merged
fix(landing): stabilize TextRotator and improve hero layout#120
Conversation
Render a fixed number of children and toggle visibility via CSS class instead of conditional rendering. Properly clean up setTimeout via useEffect to prevent stale state updates on unmount. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Split headline into two lines and left-align rotator text so "you" aligns with "your team" start position during transitions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
Code ReviewNo issues found. All 5 review dimensions passed:
Generated with Claude Code If useful, react with a thumbs-up. Otherwise, thumbs-down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeChildTypeError 수정: 조건부 DOM 삽입 대신 안정적인 자식 구조 + CSS 가시성 토글See how [you/your team]/make AI slop.Changes
6791c95fix(landing): stabilize TextRotator DOM to prevent removeChild error88797darefactor(landing): improve hero headline layout with explicit line breakTest Plan
removeChild에러 재현되지 않음Supersedes #119
Generated with Claude Code using /ship-it