Skip to content

Conversation

@AK391
Copy link
Contributor

@AK391 AK391 commented Mar 10, 2022

follow up on #498, adds spaces column and badges that link to the onnx org

@AK391 AK391 mentioned this pull request Mar 10, 2022
@garymm
Copy link
Contributor

garymm commented Mar 10, 2022

Cool!
What determines whether or not a model gets a Spaces link?
Could you add that detail to he README.md?

@AK391
Copy link
Contributor Author

AK391 commented Mar 10, 2022

@garymm Hi, we plan to add all the models here to the org https://huggingface.co/onnx and link the spaces in the table. This is the first batch of several as PRs.

Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Before going forward, please fix the DCO issue. All repos under ONNX need author to sign-off every commit. You need to forcely push to make old commits have sign-off as well.

AK391 added 7 commits March 10, 2022 16:55
Signed-off-by: AK391 <ahsen@huggingface.co>
Signed-off-by: AK391 <ahsen@huggingface.co>
Signed-off-by: AK391 <ahsen@huggingface.co>
Signed-off-by: AK391 <ahsen@huggingface.co>
Signed-off-by: AK391 <ahsen@huggingface.co>
Signed-off-by: AK391 <ahsen@huggingface.co>
Signed-off-by: AK391 <ahsen@huggingface.co>
@AK391
Copy link
Contributor Author

AK391 commented Mar 10, 2022

@jcwchen thanks all commits should be signed off now following the DCO below
Screen Shot 2022-03-10 at 4 58 01 PM

@AK391
Copy link
Contributor Author

AK391 commented Mar 11, 2022

@jcwchen let me know if there is anything else thanks!

Copy link
Member

@jcwchen jcwchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @AK391 so much for the effort to add ONNX models in HuggingFace Spaces. It's good to see now some ONNX models have live demos.

@jcwchen jcwchen merged commit 603c703 into onnx:main Mar 13, 2022
jcwchen pushed a commit to jcwchen/models that referenced this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants