Add support for Erf and Selu in transpose_optimizer.py. #2306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I guess the failures are relative to CI pipeline, not your changes. Could you please update your branch with latest changes and see if it passed? |
Signed-off-by: Alexis Tsogias <a.tsogias@cellumation.com>
Collaborator
|
Looks like your latest commit doesn't trigger those CI pipeline with unknown reasons. Do you mind closing this PR and re-open a new one with same changes to start a new iteration so CI pipeline could work well? |
Contributor
Author
|
Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for Erf (for Gelu) and Selu to transpose_optimizer.py as our models use them and the resulting onnx models had far too many transpose operations.