Update and Add links to the symbolic opset files#124
Merged
houseroad merged 1 commit intoonnx:masterfrom May 29, 2019
MAXEE998:patch-1
Merged
Update and Add links to the symbolic opset files#124houseroad merged 1 commit intoonnx:masterfrom MAXEE998:patch-1
houseroad merged 1 commit intoonnx:masterfrom
MAXEE998:patch-1
Conversation
Hi, The original link to symbolic.py is no longer working since now there are multiple files for definitions of symbolic operator functions. Perhaps providing the links to the helper file and to the new opset files is the best fix? I also add the link to torch/csrc/autograd/generated/VariableType.h, for the sake of convenience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
The original link to symbolic.py is no longer working since now there are multiple files for definitions of symbolic operator functions. Perhaps providing the links to the helper file and to the new opset files is the best fix? I also add the link to torch/csrc/autograd/generated/VariableType.h, for the sake of convenience.