Fix benchmark Caffe2 model#147
Merged
vinitra-zz merged 4 commits intoonnx:masterfrom Jul 2, 2020
Merged
Conversation
*onnx_graph_to_caffe2_net takes onnx_model as argument and not the graph *Modify bechmark_caffe2_model function to match the same method used in the already built in benchmark_pytorch_model
|
|
vinitra-zz
reviewed
Jul 2, 2020
vinitra-zz
left a comment
vinitra-zz
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution. (Sorry for the late review).
vinitra-zz
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*onnx_graph_to_caffe2_net takes onnx_model as an argument and not the graph
*Modify bechmark_caffe2_model function to match the same method used in the already built in benchmark_pytorch_model so that the comparison will make sense.