Skip to content

ONNX-Tensorflow Frontend Tutorial#27

Merged
prasanthpul merged 6 commits intoonnx:masterfrom
tjingrant:patch-2
May 15, 2018
Merged

ONNX-Tensorflow Frontend Tutorial#27
prasanthpul merged 6 commits intoonnx:masterfrom
tjingrant:patch-2

Conversation

@tjingrant
Copy link
Copy Markdown
Contributor

This is a tutorial for the frontend part of onnx-tensorflow.

cc @fumihwh, @jamesr66a

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 29, 2018

CLA assistant check
All committers have signed the CLA.

Comment thread tutorials/OnnxTensorflowExport.ipynb Outdated
" - *Graph definition*: You need to obtain information about the graph definition in the form of GraphProto. The easiest way to achieve this is to use the following snippet of code as shown in the example training script:\n",
"```\n",
" with open(\"graph.proto\", \"wb\") as file:\n",
" graph = tf.get_default_graph().as_graph_def(add_shapes=True)\n",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this indentation isn't showing up when this is rendered as markdown

@tjingrant
Copy link
Copy Markdown
Contributor Author

@jamesr66a seems to be fine now.

@dzhulgakov
Copy link
Copy Markdown
Contributor

cc @bddppq

Also, did we reach conclusion which of the TF frontends we advertise here (this vs https://github.com/onnx/tensorflow-onnx ) cc @prasanthpul

@tjingrant
Copy link
Copy Markdown
Contributor Author

@dzhulgakov not really but I don't see any problem advertising both for now and resolve this issue during our next meeting?

@dzhulgakov
Copy link
Copy Markdown
Contributor

I guess it's fine. I'm just making sure there's some longer term plan here.

Thanks for adding the example!

@prasanthpul
Copy link
Copy Markdown
Member

@tjingrant Hope you got the email I sent you last week to connect and discuss?

@tjingrant
Copy link
Copy Markdown
Contributor Author

@prasanthpul ahh it was you!

Sorry I'm having trouble mapping your github handle to your email address; also that's my personal email, so sorry for not attending it as much as I should be.

@tjingrant
Copy link
Copy Markdown
Contributor Author

@jamesr66a ? Shall we move forward?

@tjingrant
Copy link
Copy Markdown
Contributor Author

@jamesr66a @prasanthpul can you merge this? It's been a while now. Do we have any additional concerns?

@prasanthpul prasanthpul merged commit 70d57df into onnx:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants