Skip to content

Move workflows to .github, add helper actions#7

Merged
eb-oss merged 3 commits intoonosproject:masterfrom
eb-oss:add-release-workflow
May 5, 2025
Merged

Move workflows to .github, add helper actions#7
eb-oss merged 3 commits intoonosproject:masterfrom
eb-oss:add-release-workflow

Conversation

@eb-oss
Copy link
Copy Markdown
Contributor

@eb-oss eb-oss commented Mar 4, 2025

As we move to a library of reusable actions, we need to have workflows that are more adaptable to small changes in the process. To that end, we want to move as many functions out to individual actions as possible, so that these are centralized and easily editable, and can be easily called from various steps.

@eb-oss eb-oss requested a review from Copilot March 4, 2025 02:43

This comment was marked as resolved.

As we move to a library of reusable actions, we need to have
workflows that are more adaptable to small changes in the process.
To that end, we want to move as many functions out to individual
actions as possible, so that these are centralized and easily
editable, and can be easily called from various steps.

Signed-off-by: Eric Ball <eball@linuxfoundation.org>
@eb-oss eb-oss force-pushed the add-release-workflow branch from c8f215d to ada32f9 Compare March 11, 2025 19:47
This includes several of the mini-workflows from the omec-project
reusable workflow library.

Signed-off-by: Eric Ball <eball@linuxfoundation.org>
@eb-oss
Copy link
Copy Markdown
Contributor Author

eb-oss commented Apr 23, 2025

@llpeterson @gab-arrobo While this is not the final version, this is a good place to start. These workflows are everything needed to test with roc-helm-charts and onos-lib-go, and once those are verified, we can move on to implementing in all repos.

In order to view how these are implemented, I've opened the PRs here:
onosproject/roc-helm-charts#10
onosproject/onos-lib-go#298

Copy link
Copy Markdown

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me

@gab-arrobo gab-arrobo requested a review from SeanCondon April 30, 2025 19:33
@gab-arrobo
Copy link
Copy Markdown

BTW, why is this PR pointing to add-release-workflow instead of master? Should not it be directed towards master?

Signed-off-by: Eric Ball <eball@linuxfoundation.org>
@eb-oss eb-oss changed the base branch from add-release-workflow to master May 5, 2025 21:55
@eb-oss
Copy link
Copy Markdown
Contributor Author

eb-oss commented May 5, 2025

BTW, why is this PR pointing to add-release-workflow instead of master? Should not it be directed towards master?

Yes, I've fixed that now.

Copy link
Copy Markdown

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@eb-oss eb-oss merged commit ec6b68a into onosproject:master May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants