Add npm-shrinkwrap.json with jasmine-core@2.0.4 #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents Travis builds from breaking due to jasmine-core@2.1.2
josephfrazier
pushed a commit
that referenced
this pull request
Nov 21, 2014
Add npm-shrinkwrap.json with jasmine-core@2.0.4
josephfrazier
pushed a commit
that referenced
this pull request
Nov 23, 2014
Resolves #124 without needing npm-shrinkwrap.json to force an old version of jasmine-core to be installed. See also: jasmine/jasmine@a2ac5ef https://www.pivotaltracker.com/n/projects/10606/stories/66789174 Revert "Merge pull request #124 from joseph-onsip/shrinkwrap" This reverts commit 925a609, reversing changes made to a7250d7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents Travis builds from breaking due to jasmine-core@2.1.2. Once the underlying problems in grunt-contrib-jasmine/jasmine-core are solved, we should remove npm-shrinkwrap.json.