src/WebRTC: make mediaHint always be an object literal
#44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove irrelevant/bad tests fixes onsip#34
See onsip#44 (comment) Note: I x'ed a test that I couldn't get to pass, even though the code works in practice.
Contributor
Author
Oops, I completely forgot that object keys have to be strings. It should be fixed in josephfrazier@d52ca85, but I'm having some trouble getting a test to pass. |
- [23] MediaStreamManager events (onsip#23) - [23] MediaHandler events - first cut onsip#23 - onsip#23 Media event tests - expect spy calls instead of checking flags - onsip#23 MediaStreamManager events - dedupe getUserMedia callback wrappers Also, fix the test mentioned in onsip#44 (comment)
Contributor
Author
|
josephfrazier@3b8e806 brings in the changes on the media-events branch, so merging this PR should now fix #23 as well. I also fixed and re-enabled that test from my last comment. |
- mediaHint.dataChannel
- WebRTC.MediaHandler.on('dataChannel', function (dc) {});
- WebRTC.MediaHandler.dataChannel
See wakamoleguy@7839829
… cut
Usage:
var session = new SIP.UA().invite('welcome@junctionnetworks.com', {
media: {
render: {
remote: {
audio: document.createElement('audio'),
video: document.createElement('video')
},
local: {
audio: document.createElement('audio'),
video: document.createElement('video')
}
}
}
});
wakamoleguy
added a commit
that referenced
this pull request
Jun 23, 2014
src/WebRTC: make `mediaHint` always be an object literal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove irrelevant/bad tests
fixes #34, should fix #23