Use babel-loader to transpile code #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from eslint-loader to babel-loader to allow using modern constructs such as arrow functions or ES6 classes while still retaining "compatibility" with older browsers. It's worth mentioning browsers which support WebRTC already ship with ES6 support, but at least we won't trigger parser errors on the older browsers. The cost in terms of runtime size is negligeable, the minified code grows by less than 400 bytes as a result of the switch. Note: we don't pull in any polyfills with this commit, so only ES6 constructs are supported, not using new classes such as Map or Set. We still perform linting as part of the build, by invoking eslint in the prebuild step.
Collaborator
|
This looks good to me. Eslint still runs automatically while building, and it failing still halts the build with an error. Generally speaking, longterm we would like to move to typescript, but babel is an adequate and noninvasive middle-step. |
james-criscuolo
approved these changes
Nov 27, 2017
jlaine
referenced
this pull request
Nov 27, 2017
In order to allow API consumers to register to events emitted by the client context, we need to make sure that no events are emitted until after the context has been returned. We do this by using waitForConnected, a promise to when the UA is connected. We now also emit inviteSent only once the invite *has* actually been sent. If the UA was not connected yet, the event was emitted before the invite had been sent.
Contributor
Author
|
Any chance of merging this @egreenmachine ? |
Collaborator
|
My goal is to do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from eslint-loader to babel-loader to allow using modern constructs
such as arrow functions or ES6 classes while still retaining "compatibility"
with older browsers. It's worth mentioning browsers which support WebRTC
already ship with ES6 support, but at least we won't trigger parser errors
on the older browsers.
The cost in terms of runtime size is negligeable, the minified code grows
by less than 400 bytes as a result of the switch. Note: we don't pull in
any polyfills with this commit, so only ES6 constructs are supported, not
using new classes such as Map or Set.
We still perform linting as part of the build, by invoking eslint in the
prebuild step.