Skip to content

Exclude assertions#385

Merged
jamesaoverton merged 12 commits intoontodev:masterfrom
beckyjackson:exclude-assertions
Feb 28, 2019
Merged

Exclude assertions#385
jamesaoverton merged 12 commits intoontodev:masterfrom
beckyjackson:exclude-assertions

Conversation

@beckyjackson
Copy link
Contributor

See #185

@jamesaoverton jamesaoverton modified the milestone: v1.3.0 Nov 5, 2018
@jamesaoverton jamesaoverton added this to the OBI milestone Dec 6, 2018
@jamesaoverton
Copy link
Member

I think this is not backwards compatible. Please merge the latest master and let's see what JAPICMP says.

@beckyjackson
Copy link
Contributor Author

mvn verify passes - could you point me to what you were worried about?

@jamesaoverton
Copy link
Member

Locally I tried copying the latest robot-core/pom.xml (with JAPICMP configuration updates) to this branch and running mvn verify. It failed with some JAPICMP compatility problems.

@beckyjackson
Copy link
Contributor Author

OK, I went back to ee2aec6 and it failed, but if you merge master into this branch, it passes... I think it's because new stuff got added in for 1.2.0, and this branch just wasn't up-to-date so it thinks stuff got removed.

@jamesaoverton
Copy link
Member

For OBI I just want the individuals that are used to define terms such as ‘curation status specification’. Could we add an option for --individuals definitions that includes only the individuals used in logical axioms?

@jamesaoverton
Copy link
Member

I'm happy with the feature and the code. Please resolve the conflicts and add some sort of unit test.

@jamesaoverton jamesaoverton merged commit b4b31f5 into ontodev:master Feb 28, 2019
@beckyjackson beckyjackson deleted the exclude-assertions branch May 2, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants