Fix for overlapping classes/individuals when running MIREOT extract#710
Merged
jamesaoverton merged 7 commits intomasterfrom Jul 30, 2020
Merged
Fix for overlapping classes/individuals when running MIREOT extract#710jamesaoverton merged 7 commits intomasterfrom
jamesaoverton merged 7 commits intomasterfrom
Conversation
Contributor
Author
|
Do we want to add a test for this? It works in the example from #709 but that seems like a pretty rare instance (hopefully...). |
Member
|
Because it's rare, an automated test is even more important. 😄 |
added 3 commits
July 22, 2020 09:46
Contributor
Author
|
Makes sense @jamesaoverton - I've added a test in for this |
Contributor
Author
|
Conflicts resolved, is this ready to merge @jamesaoverton ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #709
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedWhen an entity is both a class and an individual, ignore the individual and prefer the class. This required a small hack because if you just call
OntologyHelper.getEntitiy(ontology, iri)it will not return an entity that occurs as both.