Skip to content

feat(simple): increase reusability of the operator#5

Closed
tribock wants to merge 3 commits intoonzack:masterfrom
tribock:master
Closed

feat(simple): increase reusability of the operator#5
tribock wants to merge 3 commits intoonzack:masterfrom
tribock:master

Conversation

@tribock
Copy link
Copy Markdown

@tribock tribock commented Apr 2, 2020

  • remove deployment name from operator
  • add operator property to values file
  • enable operator to manage multiple components in the same namespace

@dmlabs dmlabs added enhancement New feature or request rkm-outpost rkm-outpost related issues labels Apr 2, 2020
@dmlabs
Copy link
Copy Markdown
Collaborator

dmlabs commented Apr 2, 2020

@tribock As discussed on our separate channel, it would make more sense to separate your suggested simple-operator from the rkm project, as the one can use the simple-operator also for other use cases.
Do you want to to host the project for the simple-operator or shall I?
I would also suggest the the name "patch-operator" for the new project.
What do you think?

@tribock
Copy link
Copy Markdown
Author

tribock commented Apr 3, 2020

@dmlabs I completely agree with you. As you already hosted the rkm-project I would suggest that you host the patch operator as well.

@dmlabs
Copy link
Copy Markdown
Collaborator

dmlabs commented Apr 4, 2020

@tribock I created the project https://github.com/dmlabs/patch-operator.
The project already contain your suggestions and I also invited you as a contributor.
If you are OK with it, I will close this pull request without a merge.

@tribock
Copy link
Copy Markdown
Author

tribock commented Apr 7, 2020

maybe should thing about including the patch-operator as helm chart into the existing charts. maybe this will increase the complexity of the architecture at first but i expect a bigger gain on reusaility for this operator. what do you think about it?

@dmlabs
Copy link
Copy Markdown
Collaborator

dmlabs commented Apr 7, 2020

I agree with that.
Nevertheless I prefer to first concentrate on completing the RKM features and functionality.
I will file an issue for the integration of the patch-operator, link it here and then close the pull request.

@dmlabs
Copy link
Copy Markdown
Collaborator

dmlabs commented Apr 7, 2020

Opened this issue to address the topic of this pull request:
#6

@dmlabs dmlabs closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request rkm-outpost rkm-outpost related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants